On 01/14/2014 08:15 AM, Brian Paul wrote: > On 01/14/2014 05:49 AM, Marek Olšák wrote: >> On Sat, Jan 11, 2014 at 4:19 AM, Mark Mueller <markkmuel...@gmail.com> >> wrote: >>> The predominant feedback on this adventure has been to make the >>> MESA_FORMATs >>> match the PIPE, or gallium formats but every journey I've made down that >>> path has been fraught with peril. There are some cases where >>> PIPE_FORMATs >>> are even more confusing then MESA_FORMATs*. Either there is something >>> that I >>> am missing, or there are things about the PIPE_FORMATS that people >>> aren't >>> aware of, so let me pull out some specific references. >>> >>> The first problem is that in PIPE_FORMATS there is no distinction >>> between >>> array and packed formats, and this has proven to be a big cause for >>> format >>> ambiguity that some are wanting to see addressed. One proposed >>> solution is >>> to represent array formats like (hypothetically): R8G8B8A8; and packed >>> formats as RGBA_8888 (or vice versa) in the MESA_FORMATs and >>> subsequently >>> modifying the PIPE_FORMATs to suit. But that makes RGBA_1010102 kinda >>> messy >>> (though it could be RGBA_aaa2). So then how to handle this: >>> >>> So how about a poll! Isn't that the rage these days? >>> >>> >>> Please vote on: >>> >>> >>> 1) Should MESA_FORMAT names clearly distinguish between array and packed >>> formats, yes or no? >> >> Yes. > > Agreed. > > >> >>> 2) What is your preference for array format naming convention: >>> >>> a) RGBA8888_UNORM >>> >>> b) R8G8B8A8_UNORM >>> >>> c) RGBA_UNORM8 >> >> B or C. C is cleaner, B is used by gallium. I'll leave that decision >> to you. > > I prefer C there. > > >> >>> 3) What is your preference for packed format naming convention: >>> >>> a) RGBA5551_UNORM >>> >>> b) R5G5B5A1_UNORM >> >> if the final answer to (2) is C, then B. Otherwise A. B is more >> readable for formats like Z24S8 as opposed to ZS248. > > I prefer B. > > >> >>> 4) What is your preference for naming packed formats with 10 or more >>> bits: >>> >>> a) RGBA1010102_UNORM >>> >>> b) R10G10B10A2_UNORM >>> >>> c) RGBAaaa2_UNORM >>> >>> d) Croque-monsieur >> >> Same as (3). > > B again. > > > -Brian
I agree with Brian and Michel. --Ken _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
