On 15/01/14 12:11, Marek Olšák wrote: > On Wed, Jan 15, 2014 at 12:49 PM, Emil Velikov <emil.l.veli...@gmail.com> > wrote: >> The temporary variable used to store _ColorDrawBufferIndexes must be >> signed (GLint), otherwise the following conditional will be incorrectly >> evaluated. Leading to crashes in the driver/mesa or accessing/writing >> to arbitrary memory location. The bug dates back to 2009. >> >> Cc: 10.0 9.2 9.1 <mesa-sta...@lists.freedesktop.org> >> Signed-off-by: Emil Velikov <emil.l.veli...@gmail.com> >> --- >> >> Rather old bug, spotted after Marek's recent patches covering the >> area. Curious if there is any particular reason why we do not >> enable more compiler warning messages. >> >> How do people feel on the subject of enabling more (all even) compiler >> warnings on gcc compatible compilers ? > > Some warnings tend to be annoying and not useful. For the patch: > Indeed, especially if there are thousands of them. -Wall -Wextra -Wconversion produces ~ 31k warnings :)
Although -Wtype-limits sounds very interesting. Thanks for the review Marek Emil > Reviewed-by: Marek Olšák <marek.ol...@amd.com> > > Marek > _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
