On Thu, Jan 9, 2014 at 12:14 PM, Matt Turner <matts...@gmail.com> wrote:
> From: Jordan Justen <jordan.l.jus...@intel.com>
>
> total instructions in shared programs: 1498191 -> 1487051 (-0.74%)
> instructions in affected programs: 669388 -> 658248 (-1.66%)
> GAINED: 1
> LOST: 0
This is with the closed shader-db? I think the lost cases were L4D2.
Could you retain my Signed-off-by?
> Reviewed-by: Matt Turner <matts...@gmail.com>
> ---
> Looks like my unreviewed 16 patch series from last month makes this
> patch beneficial.
Nice. :)
> I cleaned some stuff up before sending this out, like 1 - x instead
> of (x + 1) % 2 and some comments.
These changes look good.
Thanks for reviving this patch.
-Jordan
> src/glsl/opt_algebraic.cpp | 52
> ++++++++++++++++++++++++++++++++++++++++++++++
> 1 file changed, 52 insertions(+)
>
> diff --git a/src/glsl/opt_algebraic.cpp b/src/glsl/opt_algebraic.cpp
> index 05a5899..b8b69b9 100644
> --- a/src/glsl/opt_algebraic.cpp
> +++ b/src/glsl/opt_algebraic.cpp
> @@ -279,6 +279,58 @@ ir_algebraic_visitor::handle_expression(ir_expression
> *ir)
> reassociate_constant(ir, 0, op_const[0], op_expr[1]);
> if (op_const[1] && !op_const[0])
> reassociate_constant(ir, 1, op_const[1], op_expr[0]);
> +
> + /* Replace (-x + y) * a + x and commutative variations with lrp(x, y,
> a).
> + *
> + * (-x + y) * a + x
> + * (x * -a) + (y * a) + x
> + * x + (x * -a) + (y * a)
> + * x * (1 - a) + y * a
> + * lrp(x, y, a)
> + */
> + for (int mul_pos = 0; mul_pos < 2; mul_pos++) {
> + ir_expression *mul = op_expr[mul_pos];
> +
> + if (!mul || mul->operation != ir_binop_mul)
> + continue;
> +
> + /* Multiply found on one of the operands. Now check for an
> + * inner addition operation.
> + */
> + for (int inner_add_pos = 0; inner_add_pos < 2; inner_add_pos++) {
> + ir_expression *inner_add =
> + mul->operands[inner_add_pos]->as_expression();
> +
> + if (!inner_add || inner_add->operation != ir_binop_add)
> + continue;
> +
> + /* Inner addition found on one of the operands. Now check for
> + * one of the operands of the inner addition to be the negative
> + * of x_operand.
> + */
> + for (int neg_pos = 0; neg_pos < 2; neg_pos++) {
> + ir_expression *neg =
> + inner_add->operands[neg_pos]->as_expression();
> +
> + if (!neg || neg->operation != ir_unop_neg)
> + continue;
> +
> + ir_rvalue *x_operand = ir->operands[1 - mul_pos];
> +
> + if (!neg->operands[0]->equals(x_operand))
> + continue;
> +
> + ir_rvalue *y_operand = inner_add->operands[1 - neg_pos];
> + ir_rvalue *a_operand = mul->operands[1 - inner_add_pos];
> +
> + if (x_operand->type != y_operand->type ||
> + x_operand->type != a_operand->type)
> + continue;
> +
> + return lrp(x_operand, y_operand, a_operand);
> + }
> + }
> + }
> break;
>
> case ir_binop_sub:
> --
> 1.8.3.2
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev
_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
