On 27 October 2013 14:59, Ian Romanick <i...@freedesktop.org> wrote:
> From: Gregory Hainaut <gregory.hain...@gmail.com>
>
> The return value has been unused since commit d348b0c. This was
> originally included in another patch, but it was split out by Ian
> Romanick.
>
> Reviewed-by: Ian Romanick <ian.d.roman...@intel.com>
> Cc: Eric Anholt <e...@anholt.net>
> ---
> src/mesa/main/shaderapi.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/src/mesa/main/shaderapi.c b/src/mesa/main/shaderapi.c
> index f5c04b9..18b4f55 100644
> --- a/src/mesa/main/shaderapi.c
> +++ b/src/mesa/main/shaderapi.c
> @@ -926,7 +926,7 @@ _mesa_active_program(struct gl_context *ctx, struct
> gl_shader_program *shProg,
>
> /**
> */
> -static bool
> +static void
> use_shader_program(struct gl_context *ctx, GLenum type,
> struct gl_shader_program *shProg)
> {
> @@ -955,7 +955,7 @@ use_shader_program(struct gl_context *ctx, GLenum type,
> }
> break;
> default:
> - return false;
> + return;
> }
>
> if (*target != shProg) {
> @@ -982,10 +982,10 @@ use_shader_program(struct gl_context *ctx, GLenum
> type,
> }
>
> _mesa_reference_shader_program(ctx, target, shProg);
> - return true;
> + return;
> }
>
> - return false;
> + return;
>
Personally, I'd just drop this final "return", since it's the end of the
function.
Either way, the patch is:
Reviewed-by: Paul Berry <stereotype...@gmail.com>
> }
>
> /**
> --
> 1.8.1.4
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev
>
_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
