On 10/25/2013 02:49 PM, Eric Anholt wrote: > Matt and I had each screwed up these common required patterns recently, in > ways that wouldn't have been noticed for a long time if not for code > review. Just enforce it in the caller so that we don't rely on code > review catching these bugs. > --- > src/glsl/opt_algebraic.cpp | 117 > +++++++++++++++------------------------------ > 1 file changed, 39 insertions(+), 78 deletions(-)
Yes, thank you! These first two patches are great. Much less likely to botch things after the first patch, and I've been meaning to convert a bunch of our code to IR builder, but never got to it. Thanks for beating me to it :) All three are: Reviewed-by: Kenneth Graunke <kenn...@whitecape.org> _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
