On 10/25/2013 01:35 PM, Emil Velikov wrote: > On 21/10/13 23:23, Bryan Cain wrote: >> This is a port of 4da54c91d24da ("nvc0: implement multisample textures") to >> nv50. >> >> When coupled with the patch to only report 16 texture samplers (to fix >> crashes), all of the Piglit tests in spec/arb_texture_multisample pass. >> > Hello Bryan, > > Big thanks for your work. As promised here is a quick piglit summary on > my nv96 > > pass/fail/crash > 69/32/27 > > * dmesg does not spit anything nouveau related during the tests > * any geometry shader related tests were skipped > (piglit: info: Failed to create GL 3.2 core context) > * all the crashes are due to the following assert > codegen/nv50_ir_emit_nv50.cpp:1393:emitTEX: Assertion `argc <= 4' failed. > > PASS arb_texture_multisample-* > PASS fb-completeness/* > FAIL sample-position/* > FAIL texelFetch fs sampler2DMS 4* > CRASH texelFetch fs sampler2DMSArray 4* > FAIL texelFetch/*-*s-isampler2DMS > CRASH texelFetch/*-*s-isampler2DMSArray > PASS textureSize/* > > > Hope you find this useful :) > No real world apps that use multisample textures were tested, yet. > > Cheers > Emil
Hi Emil, Thanks for testing on nv96. It seems, though, that I messed up my piglit-run command and didn't include all of the relevant tests as a result. Now that I've fixed that, I'm seeing the same failures and crashes on my nva5. It seems that multisampling is broken with texelFetch (both the texelFetch and sample-position tests use it) but works otherwise, unless it turns out not to produce the right results in real world applications for pre-nva3 cards. I'm going to take some time this weekend to see what's going on with multisampling and texelFetch. Thanks again, Bryan _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev