On 09/19/2013 10:46 AM, Gaetan Nadon wrote: > On 13-09-18 09:41 PM, Kenneth Graunke wrote: [snip] >> This looks good to me. There are a couple of other instances of >> X11_CFLAGS in the codebase as well. Presumably those need to be changed >> as well? > > These did not break the build for me. I don't know if X11_INCLUDES would > be needed, > or if X11_CFLAGS is just dead code. Perhaps the C code that needed it > was ifdef out.
Huh. Maybe it is just unnecessary then. > ./src/gallium/targets/libgl-xlib/Makefile.am:AM_CFLAGS = $(X11_CFLAGS) > ./src/gallium/state_trackers/egl/Makefile.am: $(X11_CFLAGS) \ > ./src/gallium/state_trackers/glx/Makefile.am: $(X11_CFLAGS) > ./src/glx/tests/Makefile.am: $(X11_CFLAGS) > ./src/mesa/main/tests/Makefile.am: $(X11_CFLAGS) \ > > > My first post on mesa. What's the next step? Repost with your review tag > for the committer? > I commit on X.Org modules, but don't think I can on mesa. > > Have you also looked at the same patch for gallium/winsys/sw/xlib, or > would this be someone else? I've gone ahead and pushed both. Thanks for the patches! _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
