Paul Berry <stereotype...@gmail.com> writes: > On 17 September 2013 14:14, Francisco Jerez <curroje...@riseup.net> wrote: > >> Paul Berry <stereotype...@gmail.com> writes: >> >> > On 17 September 2013 12:18, Paul Berry <stereotype...@gmail.com> wrote: >> >[...] >> > I also notice that most of your uses of atomic_size() in this patch >> series >> > are merely to see whether the type contains any atomics. You might >> > consider adding a contains_atomic() function (like we've already done >> with >> > contains_sampler() and contains_integer()) just for code clarity. >> >> Not really, we also need the actual size in a couple of places, like >> ast_to_hir.cpp:2256, link_atomics.cpp:80 and link_atomics.cpp:123. >> >> Thanks. >> > > I wasn't suggesting replacing it. I was suggesting adding a > contains_atomic() function so that in those places where we don't need the > actual size (which are the majority of cases) the code would be clearer. > > contains_atomic() might just be an inline function that calls atomic_size().
Oh, right... I will do that. Thank you.
pgpPERS1vpeme.pgp
Description: PGP signature
_______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
