On 08/26/2013 03:12 PM, Paul Berry wrote:
[snip]
[PATCH 01/22] i965: rename legacy gs structs and functions to ff_gs.
[PATCH 02/22] i965: Rename user-defined gs structs from vec4_gs to gs.
[PATCH 03/22] i965: Move vec4 register allocation data structures to brw->vec4.
[PATCH 04/22] i965/gs: Update defines related to GS surface organization.
These are:
Reviewed-by: Kenneth Graunke <kenn...@whitecape.org>
[PATCH 05/22] i965: Move data from brw->vs into a base class if gs will also
need it.
This one is not. The idea is great but I'm bikeshedding the names
(sorry!). Assuming we can agree on a name, and you do the search and
replace, I don't need to see a v3 to give it a R-b.
[PATCH 06/22] i965/gs: Create brw_context::gs structure to track GS program
state.
[PATCH 07/22] i965: Make CACHE_NEW_GS_PROG.
[PATCH 08/22] i965/gs: Allocate URB space for use by GS.
Whether or not you take my suggestions on 08, these are:
Reviewed-by: Kenneth Graunke <kenn...@whitecape.org>
[PATCH 09/22] i965/gs: Allocate push constant space for use by GS.
I'd like this split in two. With that change, both parts get my R-b.
[PATCH 10/22] i965: Make sure constants re-sent after constant buffer
reallocation.
[PATCH 11/22] i965: generalize brw_vs_pull_constants in preparation for GS.
[PATCH 12/22] i965/vs: generalize brw_vs_binding_table in preparation for GS.
[PATCH 13/22] i965/gs: Implement support for geometry shader surfaces.
[PATCH 14/22] i965/gs: make the state atom for compiling Gen7 geometry shaders.
[PATCH 15/22] i965/vs: generalize gen6_vs_push_constants in preparation for GS.
[PATCH 16/22] i965: Modify signature to update_texture_surface functions.
[PATCH 17/22] i965/gs: generalize brw_texture_surfaces in preparation for gs.
[PATCH 18/22] i965/gs: add geometry shader support to brw_texture_surfaces.
[PATCH 19/22] i965/gs: Implement support for geometry shader samplers.
These are:
Reviewed-by: Kenneth Graunke <kenn...@whitecape.org>
[PATCH 20/22] i965/gen7: merge defines for 3DSTATE{VS,GS,WM} dword 2
I'm completely ambivalent about this patch. If Eric or others like it,
I won't object. I did have a comment.
[PATCH 21/22] i965/gen7: Generalize gen7_vs_state in preparation for GS.
[PATCH 22/22] i965/gs: Add a state atom to set up geometry shader state.
NAK on these two. Sorry :(
That's my review. Hopefully others will have comments soon.
Thanks again for all your hard work on this, Paul. You're doing a
terrific job.
--Ken
_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
