On 20 August 2013 11:30, Paul Berry <stereotype...@gmail.com> wrote: > From: Eric Anholt <e...@anholt.net> > > All but two of the piglit GLSL 1.50/uniform_buffer tests work, and > maxuniformblocksize and referenced-by-shader work. > > v2 (Paul Berry <stereotype...@gmail.com>): Account for Ken's recent > binding table re-work. Use brw->vec4_gs.bind_bo_offset instead of > brw->gs.bind_bo_offset. > --- > src/mesa/drivers/dri/i965/Makefile.sources | 1 + > src/mesa/drivers/dri/i965/brw_context.h | 17 ++- > src/mesa/drivers/dri/i965/brw_gs_emit.c | 2 +- > src/mesa/drivers/dri/i965/brw_gs_surface_state.c | 182 > +++++++++++++++++++++++ > src/mesa/drivers/dri/i965/brw_state.h | 3 + > src/mesa/drivers/dri/i965/brw_state_upload.c | 3 + > src/mesa/drivers/dri/i965/gen6_sol.c | 6 +- > 7 files changed, 208 insertions(+), 6 deletions(-) > create mode 100644 src/mesa/drivers/dri/i965/brw_gs_surface_state.c >
>From our in-person code review yesterday: It became clear that I don't understand this patch as well as I should. I need to spend more time reviewing it myself. The ascii art tables in brw_context.h (around line 607, just above SURF_INDEX_DRAW()) should be updated.
_______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
