On 07/28/2013 11:03 PM, Paul Berry wrote:
This patch series implements preliminary front-end support for geometry shaders in Mesa. It is based on work done by myself, Bryan Cain, Eric Anholt, and Fabian Bieler over the last several months. For the patches that aren't mine, I've preserved the original authorship information, and added notes in the commit messages to indicate what I've changed.
[snip]
Except where I've voiced concerns.... [snip]
[PATCH 01/34] glsl/linker: Make update_array_sizes apply to just uniforms. [PATCH 02/34] glsl: Add EXT_texture_array support for geometry shaders. [PATCH 03/34] glsl: Enable various extensions for geometry shaders. [PATCH 04/34] main: Fix geometry shader error messages (missing right paren) [PATCH 05/34] main: Allow for the possibility of GL 3.2 without ARB_geometry_shader4.
Reviewed-by: Kenneth Graunke <kenn...@whitecape.org>
[PATCH 06/34] draw/gs: fix allocation of buffer for GS output vertices
I don't plan to review this.
[PATCH 07/34] mesa: account for geometry shader texture fetches in update_texture_state
Reviewed-by: Kenneth Graunke <kenn...@whitecape.org>
[PATCH 08/34] mesa/st: Add VARYING_SLOT_TEX[1-7] to st_translate_geometry_program().
I don't plan to review this.
[PATCH 09/34] glsl: add ir_emitvertex and ir_endprim instruction types [PATCH 10/34] glsl: add builtins for geometry shaders. [PATCH 11/34] glsl: support compilation of geometry shaders [PATCH 12/34] mesa: Refactor copying of linked program data. [PATCH 13/34] mesa: Copy linked program data for GS. [PATCH 14/34] glsl: Require geometry shader inputs to be arrays. [PATCH 15/34] glsl/linker: Properly error check VS-GS linkage.
Reviewed-by: Kenneth Graunke <kenn...@whitecape.org>
[PATCH 16/34] glsl/linker: Properly pack GS input varyings. [PATCH 17/34] glsl: Modify varying packing to use a temporary exec_list. [PATCH 18/34] glsl: Properly pack GS output varyings
I don't plan to review these.
[PATCH 19/34] mesa/shaderapi: Allow 0 GEOMETRY_VERTICES_OUT. [PATCH 20/34] mesa: Validate the drawing primitive against the geometry shader input primitive type. [PATCH 21/34] glsl/linker: Fail to link geometry shader without vertex shader. [PATCH 22/34] main: Fix delete_shader_cb() for geometry shaders
Reviewed-by: Kenneth Graunke <kenn...@whitecape.org>
[PATCH 23/34] st/mesa, glsl_to_tgsi: add support for geometry shaders [PATCH 24/34] gallivm: Fix indirect input fetches for gs. [PATCH 25/34] gallium/draw: Pass primitive ID as integer to the shader. [PATCH 26/34] mesa/st: Allow geometry shaders without gl_Position export.
I don't plan to review these.
[PATCH 27/34] glsl: Make sure that we don't put too many bitfields in ast_type_qualifier. [PATCH 28/34] glsl: Parse the GLSL 1.50 GS layout qualifiers. [PATCH 29/34] glsl: Export the compiler's GS layout qualifiers to the gl_shader. [PATCH 30/34] glsl: Cross-validate GS layout qualifiers while intrastage linking. [PATCH 31/34] glsl: Permit non-ubo input interface arrays to use non-const indexing. [PATCH 32/34] glsl: Allow geometry shader input instance arrays to be unsized. [PATCH 33/34] glsl: Implement rules for geometry shader input sizes. [PATCH 34/34] main: Warn that geometry shader support is experimental.
Reviewed-by: Kenneth Graunke <kenn...@whitecape.org> _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
