> From: Roland Scheidegger <srol...@vmware.com> > > llvm shifts are undefined for shift counts exceeding (or matching) bit width, > so need to apply a mask for the tgsi shift instructions. > > v2: only use mask for the tgsi shift instructions, not for the build shift > helpers. None of the internal callers need this behavior, and while llvm can > optimize away the masking for constants there are legitimate cases where it > might not be able to do so even if we know that shift count must be smaller > than type width (currently all such callers do not use the build shift > helpers).
Looks good to me _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev