There are a couple of reasons why this was missed: 1) The depth texture mode doesn't exist in the core profile, so the core spec doesn't and cannot specify what the default should be, so that's why nobody updated it. However the 4.1 core spec says:
"3.8.9 Depth Component Textures Depth textures and the depth components of depth/stencil textures can be treated as RED textures during texture filtering and application (see section 3.8.16). The initial state for depth and depth/stencil textures treats them as RED textures." 2) The default TBO format is LUMINANCE8 according to the ARB_tbo spec, so apparently the default value was copied from there. However the GL core spec is different again and says R8 is the default format. This was also missed because the piglit test expects LUMINANCE8 and also because proprietary drivers don't support 3.1 without ARB_compatibility (I assume the piglit tests had been tested on proprietary drivers first). I guess we should stop exposing ARB_tbo, because it conflicts with the GL core spec. BTW I have also sent some fixes for piglit. We just lack a test for the depth textures being treated as RED by default. Marek On Mon, Jul 22, 2013 at 10:52 PM, Kenneth Graunke <kenn...@whitecape.org> wrote: > On 07/22/2013 10:37 AM, Ian Romanick wrote: >> >> Crap. I thought we had already done this. Do we have a piglit test for >> this? I'm just curious how we missed it... >> >> Either way, both patches are >> >> Reviewed-by: Ian Romanick <ian.d.roman...@intel.com> > > > I'm very skeptical of these patches, having looked at it a bunch - I'll try > and find time to respond properly today or tomorrow. _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
