On 07/15/2013 01:41 PM, Ian Romanick wrote:
On 07/15/2013 07:28 AM, Tomasz Lis wrote:
The change is to correctly handle the value of renderType in both
fbconfig and context. Uses of renderType are commented, where needed,
to avoid confusion between the two types. The fact that float configs
can be only used for pbuffers is correctly addressed.
These commit messages are not so good. The first line should be a short
description of the change. The remainder should be additional
information (details or supporting evidence) of the change. For this
patch, I would suggest:
Correctly handle the value of renderType in both fbconfig and context.
Uses of renderType are commented, where needed, to avoid confusion
between the two types. The fact that float configs can be only used
for pbuffers is correctly addressed.
Also, commit messages for the glx code should start with the "glx:"
prefix, i.e.
glx: Correctly handle renderType in both fbconfig and context.
In general, to figure out the prefix for a particular directory, run git
log on a file you edited and see what other people have picked.
Patches 1-3 look reasonable to me; I didn't get a chance to look at the
rest of the series, but I trust Ian's review.
--Ken
_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
