On 07/12/2013 08:06 AM, Jose Fonseca wrote:
The tradition has been to use "C" suffix for conditional opcodes, instead of 
"_IF".  That said, I don't feel too strongly either way.

I agree that the current naming is confusing. And I like the fact that the new 
and old opcodes don't overlap, which means there is no way we inadvertently get 
the wrong ones when updating out-of-tree state trackers.

And it's nice to see this sort of cleanups. I know from experience that that 
they can be time consuming, but I do believe they pay up eventually. I believe 
Gallium pipe_screen/pipe_context interfaces are quite lean and straightforward 
these days, but the opcodes are still a big mess, and shaders are one of the 
most (if not the most) important parts of the interface.

For the series:
Reviewed-by: Jose Fonseca <jfons...@vmware.com>

Thanks. As I've been explaining some of the nuances of gallium/TGSI to our intern this summer it's really obvious when something's wrong or inconsistent.

-Brian

_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Reply via email to