On 04/22/2013 12:38 AM, christopher.halse.rog...@canonical.com wrote:
From: Christopher James Halse Rogers<r...@ubuntu.com>
---
src/gallium/drivers/r300/r300_screen.c | 8 ++-
src/gallium/drivers/r300/r300_texture.c | 2 +-
src/gallium/drivers/r600/r600_pipe.c | 7 ++-
src/gallium/drivers/r600/r600_texture.c | 2 +-
src/gallium/drivers/radeonsi/r600_texture.c | 2 +-
src/gallium/drivers/radeonsi/radeonsi_pipe.c | 6 +-
src/gallium/winsys/radeon/drm/radeon_drm_bo.c | 70 ++++++++++++++++++-----
src/gallium/winsys/radeon/drm/radeon_drm_winsys.c | 4 ++
src/gallium/winsys/radeon/drm/radeon_winsys.h | 3 +
9 files changed, 84 insertions(+), 20 deletions(-)
diff --git a/src/gallium/drivers/r300/r300_screen.c
b/src/gallium/drivers/r300/r300_screen.c
index 000c71d..b7a7a2d 100644
--- a/src/gallium/drivers/r300/r300_screen.c
+++ b/src/gallium/drivers/r300/r300_screen.c
@@ -28,6 +28,8 @@
#include "vl/vl_decoder.h"
#include "vl/vl_video_buffer.h"
+#include<drm.h>
[...]
Just a high-level comment: isn't including DRM-related stuff in the
driver an interface violation? That is, shouldn't all the DRM stuff
be contained in the winsys module?
A guiding principle of gallium drivers is that they only contain
device-specific code, not window system or OS-specific code.
-Brian
_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
