On 18/04/13 01:21, Paul Berry wrote: > On 12 April 2013 01:26, Christian König <deathsim...@vodafone.de> wrote: > >> From: Christian König <christian.koe...@amd.com> >> >> Since we now have UVD support we should enable them by default. >> >> Signed-off-by: Christian König <christian.koe...@amd.com> >> > > Those of us who don't build Gallium now need to add > "--disable-gallium-g3dvl" to our configure parameters, or the build fails > with the error message "configure: error: cannot enable G3DVL without > Gallium". > > Is it possible to change this so that the default is "if building gallium, > enable g3dvl, else disable g3dvl"? > The attached patch should change the behaviour from "always enable" to "enable if building gallium". Please review/test Btw, I do not have commit access, so feel free to commit
Emil > > > _______________________________________________ > mesa-dev mailing list > mesa-dev@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/mesa-dev >
>From 0b90d5bff8c131930760866c45e01ab70598e48f Mon Sep 17 00:00:00 2001 From: Emil Velikov <emil.l.veli...@gmail.com> Date: Thu, 18 Apr 2013 01:40:40 +0100 Subject: [PATCH] configure: enable vdpau and xvmc detection, when gallium is present Currently enable-gallium-g3vl guards the vdpau and xvmc detection code. The former explicitly checks if gallium is being built and bails out if it doesn't. Workaround by performing the vdpau/xvmc detection only when at least one gallium driver is in the works Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=63645 Signed-off-by: Emil Velikov <emil.l.veli...@gmail.com> --- configure.ac | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/configure.ac b/configure.ac index ba92258..4fcb75a 100644 --- a/configure.ac +++ b/configure.ac @@ -1319,9 +1319,15 @@ dnl Gallium G3DVL configuration dnl AC_ARG_ENABLE([gallium-g3dvl], [AS_HELP_STRING([--disable-gallium-g3dvl], - [build gallium g3dvl @<:@default=enabled@:>@])], + [build gallium g3dvl @<:@default=auto@:>@])], [enable_gallium_g3dvl="$enableval"], - [enable_gallium_g3dvl=yes]) + [enable_gallium_g3dvl=auto]) +if test "x$enable_gallium_g3dvl" = xauto -a; then + if test "x$with_gallium_drivers" != x; then + $enable_gallium_g3dvl=yes + fi +fi + if test "x$enable_gallium_g3dvl" = xyes; then if test "x$with_gallium_drivers" = x; then AC_MSG_ERROR([cannot enable G3DVL without Gallium]) -- 1.8.2.1
_______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
