gregory hainaut <gregory.hain...@gmail.com> writes: > On Fri, 12 Apr 2013 12:38:19 -0700 > Eric Anholt <e...@anholt.net> wrote: > >> Please, patches for Mesa have to actually be addressed to Mesa. > > What do you mean? The github tree (was requested by Jordan)? Or > because the mail header doesn't contains mesa address (mail client > setup issue that it is now fixed) ?
The mail header. >> > + <function name="GenProgramPipelines" offset="assign"> >> > + <param name="n" type="GLsizei" /> >> > + <param name="pipelines" type="GLuint *" /> >> > + </function> >> > + <function name="IsProgramPipeline" offset="assign"> >> > + <param name="pipeline" type="GLuint" /> >> > + <return type="GLboolean"/> >> > + </function> >> >> Missing ProgramParameteri here. > Unfortunately it complains about duplication. The function is already defined > in ARB_get_program_binary.xml. I could put a dummy name with an alias. > I don't see any specific syntax on the python. Ah, it already exists. Great. (A little comment here would be reasonable) >> I'm surprised this patch builds -- I thought we had requirements that >> Mesa functions be present for all the new stuff in the API XML right >> away (unless explicitly marked somehow), but the uniform double >> functions aren't present. Have you run make check on this patch? >> > Normally it must build fine except if I screw up on a rebase. I comment the > uniform double on the xml. If you prefer I can reenable them on the xml and > put dummy uniform function. Oh, I missed that the whole block was commented out in the XML -- I thought the comment block was closed. Makes sense now.
pgpMELrcHtdKU.pgp
Description: PGP signature
_______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
