On Mon, Feb 25, 2013 at 8:55 PM, Ian Romanick <i...@freedesktop.org> wrote: > Also... are there piglit tests coming? Not unless you convince me otherwise. I don't think I'll be able to verify that said tests work however.
> More recent versions of the spec template include a section for describing > conformance tests. This would be a good place to document piglit tests. It > also helps app developers know how things should work. Where is this template? > Interactions with GL_ARB_texture_view? Really, texture views seem like the > right way to do this. GL_ARB_texture_view doesn't interact with EGL images at all from what I can see. > What if the underlying driver doesn't support sRGB? It should just return EGL_BAD_VIEW_MESA then. > Since this extension > depends on KHR_image_base, the enable needs to at least depend on > dri2_dpy->image. > Shouldn't attrs sill be const? If Mesa does const by default, then sure. > Why can't I create an sRGB view of a pixmap? It's just a reinterpretation > of the bits. Because it's not implemented. I prefer not to touch code I won't even manually test after (no pixmaps in Wayland). > The spec doesn't give much guidance about why the > implementation may not "support creating the specified gamma view". At > least mentioning something in the issues section would be helpful. I could probably add something. > I know the ifdef stuff is used other places, but since this comes from our > own header file, I don't think it's necessary. Surrounding code had it. _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
