On 02/19/2013 05:03 PM, Matt Turner wrote:
From: Kenneth Graunke <kenn...@whitecape.org>
Previously, we had separate constructors for one, two, and four operand
expressions. This patch consolidates them into a single constructor
which uses NULL default parameters.
The unary and binary operator constructors had assertions to verify that
the caller supplied the correct number of operands for the expression,
but the four-operand version did not. Since get_num_operands for
ir_quadop_vector returns the number of vector_elements, we can safely
add that without breaking the semantics of ir_quadop_vector.
This also paves the way for expressions with three operands. Currently,
none can be constructed since get_num_operands() never returns 3.
Reviewed-by: Matt Turner <matts...@gmail.com>
For patches 1-3, and 5-6:
Signed-off-by: Kenneth Graunke <kenn...@whitecape.org>
For patches 4 and 7-9:
Reviewed-by: Kenneth Graunke <kenn...@whitecape.org>
(except for the missing gen check, which was my fault originally)
It was also rather amusing to re-read my patches, as I apparently wrote
a lot more code than I have any recollection of writing :)
Thanks for doing this, Matt!
_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
