I'd still like to have this applied.
On Tue, Dec 18, 2012 at 3:16 PM, John Kåre Alsaker <john.kare.alsa...@gmail.com> wrote: > On Tue, Dec 18, 2012 at 11:20 AM, Jose Fonseca <jfons...@vmware.com> wrote: >> Looks fine. >> >> I'm curious, what does this fix in practice? > It fixes Weston crashing when running with llvmpipe. > >> >> Jose >> >> ----- Original Message ----- >>> NOTE: This is a candidate for the stable branches. >>> --- >>> src/gallium/drivers/llvmpipe/lp_texture.c | 4 +++- >>> 1 file changed, 3 insertions(+), 1 deletion(-) >>> >>> diff --git a/src/gallium/drivers/llvmpipe/lp_texture.c >>> b/src/gallium/drivers/llvmpipe/lp_texture.c >>> index 2e9c6bf..f17a04a 100644 >>> --- a/src/gallium/drivers/llvmpipe/lp_texture.c >>> +++ b/src/gallium/drivers/llvmpipe/lp_texture.c >>> @@ -295,7 +295,9 @@ llvmpipe_resource_create(struct pipe_screen >>> *_screen, >>> /* assert(lpr->base.bind); */ >>> >>> if (resource_is_texture(&lpr->base)) { >>> - if (lpr->base.bind & PIPE_BIND_DISPLAY_TARGET) { >>> + if (lpr->base.bind & (PIPE_BIND_DISPLAY_TARGET | >>> + PIPE_BIND_SCANOUT | >>> + PIPE_BIND_SHARED)) { >>> /* displayable surface */ >>> if (!llvmpipe_displaytarget_layout(screen, lpr)) >>> goto fail; >>> -- >>> 1.8.0.2 >>> >>> _______________________________________________ >>> mesa-dev mailing list >>> mesa-dev@lists.freedesktop.org >>> http://lists.freedesktop.org/mailman/listinfo/mesa-dev >>> _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev