https://bugs.freedesktop.org/show_bug.cgi?id=61012
--- Comment #7 from Roland Scheidegger <srol...@vmware.com> --- (In reply to comment #6) > (In reply to comment #5) > > Created attachment 75068 [details] [review] [review] > > another attempt to fix pbuffer initialization > > > > Hmm is it legal to use XGetGeometry() with pbuffers? > > Not normally, but in the glx/xlib code we create a dummy pixmap for each > pbuffer so that we have an XID that we can pass around. Ah ok then that should be fine too. I think though in this case the function comment should be updated too (which is why I was thinking this function shouldn't really set up size for whatever reason). > > > > I think something like this patch would be better. > > That would be fine too. It's what I first tried. > > > Not sure if guarding against zero-sized buffers in drivers is needed. Might > > be but there are other instances where we hack up such windows to have > > width/height of 1 for that reason so we don't have to do it in drivers. > > I hacked up a test for a 0x0 surface. Softpipe worked but the llvmpipe > assertion failed. I guess I'd consider the llvmpipe change to be a > defensive coding check. One less way for llvmpipe to fail is good thing. Yeah probably. Though zero-sized resources are a pretty nasty thing. -- You are receiving this mail because: You are the assignee for the bug.
_______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
