Kenneth Graunke <kenn...@whitecape.org> writes:
> Previously, BLORP only handled BlitFramebuffer.  This patch adds an
> additional frontend for doing CopyTexSubImage.  It also makes it the
> default.

Reading through the patch, it looks like there are two independent
things happening here---extending blorp to support a copytexsubimage
operation and then preferring to use that first ti implement
CopyTexSubImage for i965.

And sure enough your commit message has "also" in it, (and even "and"
in the one-line summary).

I recommend splitting this into two commits.

> No Piglit regressions on Ivybridge.  I have not tested Sandybridge.

I just tested on Sandybridge---no piglit regressions.

Reviewed-by: Carl Worth <cwo...@cworth.org>

-Carl

-- 
carl.d.wo...@intel.com

Attachment: pgpostjTbz2nN.pgp
Description: PGP signature

_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Reply via email to