On Mon, Jan 14, 2013 at 11:35 PM, Ian Romanick <i...@freedesktop.org> wrote: > On 01/13/2013 06:20 AM, Marek Olšák wrote: >> >> Hi Dave, here's a preliminary review. >> >> 1) The depth and integer texture sample limits should be set according >> to driver support, we probably don't have good queries for that. >> >> - R6xx cannot do depth MSAA textures. >> - R6xx and R7xx cannot do integer MSAA textures. >> - Color resolve with R11G11B10_FLOAT is buggy on R6xx, so we don't >> support the format with a sample count > 1. This limitation might be >> tricky to report with ARB_texture_multisample. > > > GL_ARB_internalformat_query2 allows queries of all these sorts of things. > Mesa doesn't support it yet, but we could probably use some internal > infrastructure in this area first.
We do have some internal infrastructure in Mesa, well Gallium actually, but it's pretty much Mesa for some of us: pipe_screen::is_format_supported is very flexible and r600g does expose all its limits through that function already. I saw your ARB_internalformat_query series and I wondered why you had added a pretty limited query for the sample count to dd_function_table - QuerySamplesForFormat. It was obvious that it would have to go away and be replaced by something more useful for ARB_internalformat_query2. If you copied is_format_supported from gallium, you'd be internally almost done with ARB_internalformat_query2. I don't think we need greater flexibility than that, well maybe for pre-r600 we do. Marek _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
