On Mon, 2012-12-17 at 15:47 +0100, Michel Dänzer wrote:
> On Sam, 2012-12-15 at 23:29 +0400, Vadim Girlin wrote: 
> > ---
> 
> This patch could use more description (or maybe comments):
> 
> What was broken before, e.g. what piglit tests or other apps failed?
> 
> How does the patch fix this?

The patch fixes broken SHADOWCUBE handling - coords[3] was never defined
and caused asserts in LLVM, but now I noticed that the patch also adds
unnecessary operation for CUBE. It has no regressions though and fixes
some piglit tests for SHADOWCUBE.

I'll try to add cube arrays support and improve other things before
resending.

Vadim

_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Reply via email to