On 12/03/2012 11:05 AM, Chad Versace wrote:
On 12/01/2012 11:10 AM, Ian Romanick wrote:
From: Ian Romanick <ian.d.roman...@intel.com>

Now that _mesa_BindFramebuffer does the right thing in ES contexts when the
gl_extensions::ARB_framebuffer_object bit is set, the Intel driver doesn't
need this hack.

No piglit or GLES2 conformance regressions observed on IVB.

Signed-off-by: Ian Romanick <ian.d.roman...@intel.com>
Cc: Chad Versace <chad.vers...@linux.intel.com>
Cc: Matt Turner <matts...@gmail.com>
---
  src/mesa/drivers/dri/intel/intel_extensions.c | 3 +--
  1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/src/mesa/drivers/dri/intel/intel_extensions.c 
b/src/mesa/drivers/dri/intel/intel_extensions.c
index 9578ff0..0873e11 100755
--- a/src/mesa/drivers/dri/intel/intel_extensions.c
+++ b/src/mesa/drivers/dri/intel/intel_extensions.c
@@ -45,8 +45,7 @@ intelInitExtensions(struct gl_context *ctx)

     ctx->Extensions.ARB_draw_elements_base_vertex = true;
     ctx->Extensions.ARB_explicit_attrib_location = true;
-   if (_mesa_is_desktop_gl(ctx))
-      ctx->Extensions.ARB_framebuffer_object = true;
+   ctx->Extensions.ARB_framebuffer_object = true;
     ctx->Extensions.ARB_half_float_pixel = true;
     ctx->Extensions.ARB_internalformat_query = true;
     ctx->Extensions.ARB_map_buffer_range = true;


For the series,
Reviewed-by: Chad Versace <chad.vers...@linux.intel.com>

I'd like to point out, though, that glBindFramebufferEXT and 
glBindRenderbufferEXT
are still broken on desktop GL because they don't accept user-genned names. But
that fix belongs to a different series.

I had forgotten about that.

We've shipped this way for years. We have zero evidence of this effecting any applications, so I'm not sure we care.

_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Reply via email to