Matt Turner <matts...@gmail.com> writes: > And add a test case to ensure that this works. > > See 17f9beb6 for #if change.
The code here looks fine, (and it's surprising that #if got this treatment without #elif so long ago). Your commit message says "add a test case to ensure this works" but the only test case is in the negative sense, (flagging an invalid identifier of elif110 after the '#'). I'd like to also see a passing test with something like: #if 0 #elif(1) success #endif With that added, I give: Reviewed-by: Carl Worth <cwo...@cworth.org> to this commit and the preceding commit. (For the subsequent __LINE__ and __FILE__ I think we can do better, and I'll attempt that next.) -Carl
pgp6psKVAFpXg.pgp
Description: PGP signature
_______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
