Ian Romanick <i...@freedesktop.org> writes: > On 11/26/2012 11:19 PM, Eric Anholt wrote: >> Ian Romanick <i...@freedesktop.org> writes: >> >>> From: Ian Romanick <ian.d.roman...@intel.com> >>> >>> NOTE: This is a candidate for the 9.0 branch. >>> >>> Signed-off-by: Ian Romanick <ian.d.roman...@intel.com> >> >> Has this actually been tested for the undefined-but-not-crash cases? >> I'm guessing not -- we've got lots of assumptions that a pair of actual >> shaders exist in our driver, and I think this change means we'll deref >> NULL pointers. > > That's a fair point. These patches have been sitting in the gles3 > branch for several months. There was no change in piglit, but that > probably just means we don't have a test case for those situations. Do > you have some suggestions for test cases you think might cause problems? > I can code some up...
Well, just rendering without a vs or fs and making sure we run to completion seems like easy tests. The real interesting one would be on a core context, rendering with a vs, tfb, and raster discard but no fs.
pgpU9wSR1d209.pgp
Description: PGP signature
_______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
