Kenneth Graunke <kenn...@whitecape.org> writes: > The brw_compile structure contains the brw_instruction store and the > brw_eu_emit.c state tracking fields. These are only useful for the > final assembly generation pass; the earlier compilation stages doesn't > need them. > > This also means that the code generator for future hardware won't have > access to the brw_compile structure, which is extremely desirable > because it prevents accidental generation of Gen4-7 code.
> mem_ctx = c; > + > + p = &_p; > + brw_init_compile(brw, p, mem_ctx); Any reason not to just ralloc_zero here instead of having a funny static copy? Other than that, this looks like a pretty nice split. Other than the little comments, Reviewed-by: Eric Anholt <e...@anholt.net>
pgpaGlzfNrDnF.pgp
Description: PGP signature
_______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev