Carl Worth <cwo...@cworth.org> writes: > With this change, there's no (intended) behavioral change. The > undefined_macro_mode flag is set to UNDEFINED_MACRO_IS_ZERO only when > expanding an #if or #elif expression. All other expansions will leave the > undefined macro as an identifier.
I'm going to NAK this patch myself. I think it's excessively
over-complicated.
I believe what we can do instead is to just change the following code:
> expression:
> integer_constant
> -| IDENTIFIER {
> - $$ = 0;
> - }
to have a conditional call to glcpp_error in the case where an undefined
identifier should not have a value of zero. That's the approach Ian
suggested anyway.
I'll test that Monday morning.
-Carl
PS. I still do need a bit of guidance on what the right condition is for
this, (as mentioned in the other patch I sent previously).
pgpNvk36h8B8W.pgp
Description: PGP signature
_______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
