On 11/20/2012 05:45 PM, Ian Romanick wrote: > On 11/20/2012 05:31 PM, Chad Versace wrote: >> Set the GLES3 bit in intel_screen's bitmask of supported DRI API's. >> Neither the EGL nor GLX layer uses the bit yet. >> >> Signed-off-by: Chad Versace <chad.vers...@linux.intel.com> >> --- >> src/mesa/drivers/dri/intel/intel_screen.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/src/mesa/drivers/dri/intel/intel_screen.c >> b/src/mesa/drivers/dri/intel/intel_screen.c >> index 0194804..411dff8 100644 >> --- a/src/mesa/drivers/dri/intel/intel_screen.c >> +++ b/src/mesa/drivers/dri/intel/intel_screen.c >> @@ -1121,6 +1121,7 @@ __DRIconfig **intelInitScreen2(__DRIscreen *psp) >> #endif >> #if FEATURE_ES2 >> api_mask |= (1 << __DRI_API_GLES2); >> + api_mask |= (1 << __DRI_API_GLES3); >! > If we expose this bit, there is a reasonable expectation that an application > can > create an ES 3.0 context. However, due to other factors, this may not be > possible. Should we conditionally set this bit?
Sigh... yes. I began doing the refactoring necessary to accomplish that, but several mini-patches into it I said "Yuk! I'll procrastinate and do it later." Just as we should only set the ES3 bit if the driver is capable of creating an ES3 context, likewise we should only set the ES2 bit if the driver is capable of creating an ES2 context. However, we set the ES2 bit unconditionally on i915. Unless you say otherwise, I'll revive my patches to conditionally set the ES3 bit. _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
