On Tue, Nov 13, 2012 at 1:29 PM, Paul Berry <stereotype...@gmail.com> wrote: > On 13 November 2012 13:18, Matt Turner <matts...@gmail.com> wrote: >> >> All the other range checks on index already return the proper error, >> INVALID_VALUE. >> >> Fixes gles3conform's instanced_arrays_invalid. > > > Minor nit pick: it's not obvious from your commit subject whether it > describes the state of the code before or after the change. I'd recommend > something like "mesa: return INVALID_VALUE from VertexAttribDivisor if index > out of range".
Sure, that does sound better. Thanks! > Reviewed-by: Paul Berry <stereotype...@gmail.com> _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
