On 10/31/2012 05:37 PM, Paul Berry wrote: > On 31 October 2012 15:27, Chad Versace <chad.vers...@linux.intel.com > <mailto:chad.vers...@linux.intel.com>> wrote: > > On 10/30/2012 10:42 AM, Paul Berry wrote: > > This patch creates a header querymatrix.h, to allow functions defined > > in querymatrix.c to be used from other .c files. It also switches > > from the nonstandard GL_APIENTRY to GLAPIENTRY. > > --- > > src/mesa/main/querymatrix.c | 12 +++++------- > > src/mesa/main/querymatrix.h | 39 > +++++++++++++++++++++++++++++++++++++++ > > 2 files changed, 44 insertions(+), 7 deletions(-) > > create mode 100644 src/mesa/main/querymatrix.h > > > > diff --git a/src/mesa/main/querymatrix.c b/src/mesa/main/querymatrix.c > > index 2843d55..27842ae 100644 > > > +extern void GLAPIENTRY _mesa_GetIntegerv(GLenum pname, GLint *params); > > +extern void GLAPIENTRY _mesa_GetFloatv(GLenum pname, GLfloat *params); > > I think the local declarations of the Get functions should be removed. > Instead, > just #include "main/get.h". > > > Yeah, that seems reasonable. I'll make that change before pushing the series.
Thanks. Reviewed-by: Chad Versace <chad.vers...@linux.intel.com> _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
