On Fri, Sep 14, 2012 at 12:12:33PM +0200, Michel Dänzer wrote: > On Fre, 2012-09-14 at 11:49 +0200, Thierry Reding wrote: [...] > > Not as far as I know. Unless you add AM_MAINTAINER_MODE and run > > configure with --enable-maintainer-mode you won't get automatic > > regeneration. > > > > In fact that's the reason why I added this patch. While working on the > > cross-compile patch I noticed that the Makefile didn't get regenerated > > when the Makefile.am was modified. > > Weird, that's working for me... I haven't had to re-run autogen.sh or > anything like that in a while.
You're absolutely right. This does indeed work without maintainer mode. I must have misdiagnosed the problem. > So, I'm worrying that your change might actually cause problems, because > experience with other projects shows that some people will inevitably > end up losing --enable-maintainer-mode somehow and running into weird > breakage after updating from Git. Given the above I think this patch can be ignored. The only issue where it might be useful is to disable automatic regeneration in released tarballs, as you've mentioned before. So I guess if we want to ship Mesa tarballs with the rebuild rules disabled there might be a reason to include the patch. If that means that it could potentially break things for developers, I don't think it's worth it, though. Anyway, this patch was really just a by-product. The more important one is the cross-compilation support patch for builtin_compiler. That does solve a very real problem. =) Thierry
pgpGUymxSa5eS.pgp
Description: PGP signature
_______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
