On 09/08/2012 12:08 AM, Eric Anholt wrote:
Ian Romanick <i...@freedesktop.org> writes:
From: Ian Romanick <ian.d.roman...@intel.com>
NOTE: This is a candidate for the 9.0 branch
Signed-off-by: Ian Romanick <ian.d.roman...@intel.com>
I've reviewed up to this point, with reference to the gles3 spec to see
if anything got missed there. I noted that a bunch of things seem to
ignore GLES1, but maybe you either didn't care (valid), or something
prevented those dispatch init functions from being entered at all in
that case.
I haven't reviewed the unit test -- it wasn't clear to me where the list
of functions came from and whether they should be changed when new
extensions are added.
Yes. I'll add the following to the commit log. Does that clarify enough?
The list of expected functions originally came from the functions
set by
api_exec_es2.c. This file no longer exists in Mesa (but api_exec_es1.c
is still generated). It was the generated file that configured the
dispatch table for ES2 contexts. This test verifies that all of the
functions set by the old api_exec_es2.c (with the recent addition
of VAO
functions) are set in the dispatch table and everything else is a NOP.
When adding ES2 (or ES3) extensions that add new functions, this test
will need to be modified to expect dispatch functions for the new
extension functions.
_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
