On 09/11/2012 03:55 PM, Imre Deak wrote:
On Tue, 2012-09-11 at 09:30 -0600, Brian Paul wrote:
On 09/10/2012 12:41 AM, Imre Deak wrote:
No functional change.

Signed-off-by: Imre Deak<imre.d...@intel.com>
---
   src/mesa/main/get.c |   18 +++++++++---------
   1 file changed, 9 insertions(+), 9 deletions(-)

diff --git a/src/mesa/main/get.c b/src/mesa/main/get.c
index 24d2a18..57457ef 100644
--- a/src/mesa/main/get.c
+++ b/src/mesa/main/get.c
@@ -1442,20 +1442,20 @@ void _mesa_init_get_hash(struct gl_context *ctx)

      for (i = 0; i<   Elements(values); i++) {
         if (values[i].type == TYPE_API_MASK) {
-        api_mask = values[i].offset;
-        continue;
+         api_mask = values[i].offset;
+         continue;
         }
         if (!(api_mask&   api_bit))
-        continue;
+         continue;

         hash = (values[i].pname * prime_factor)&   mask;
         while (1) {
-        index = hash&   mask;
-        if (!table[index]) {
-           table[index] = i;
-           break;
-        }
-        hash += prime_step;
+         index = hash&   mask;
+         if (!table[index]) {
+            table[index] = i;
+            break;
+         }
+         hash += prime_step;
         }
      }


Reviewed-by: Brian Paul<bri...@vmware.com>

Do you need someone to commit these patches for you?

Yes, please.

I don't know who have commit right or what's the workflow in general, so
I just posted these in the hope that someone will commit them
eventually.

OK, I'll push 1-4 tonight or tomorrow AM.


Patches 01-04 are trivial and stand on their own, so they could be
committed right away.

05-06 containing the actual fix is also independent of the subsequent
ones, but I will post a new version with the comments addressed.

07-12 is moving the currently run-time hash generation to build time and
hasn't received any reviewed-by lines, though Ian looked through at
least some of them already.

I'd like to have a second set of eyes look that over too. It's funny that we're moving to a python-generated get.c. That's the way I had it a few years ago.

-Brian
_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Reply via email to