Brian Paul <bri...@vmware.com> writes: > On 07/31/2012 09:30 AM, Eric Anholt wrote: >> Kenneth Graunke<kenn...@whitecape.org> writes: >> >>> On 07/30/2012 03:28 PM, Brian Paul wrote: >>>> On 07/30/2012 02:13 PM, Eric Anholt wrote: >>>>> Fixes some failures in getteximage-formats. >>>>> --- >>>>> src/mesa/drivers/dri/i965/brw_wm_surface_state.c | 14 ++++++-------- >>>>> 1 file changed, 6 insertions(+), 8 deletions(-) >>>>> >>>>> diff --git a/src/mesa/drivers/dri/i965/brw_wm_surface_state.c >>>>> b/src/mesa/drivers/dri/i965/brw_wm_surface_state.c >>>>> index 65ca2fc..9e7fcf1 100644 >>>>> --- a/src/mesa/drivers/dri/i965/brw_wm_surface_state.c >>>>> +++ b/src/mesa/drivers/dri/i965/brw_wm_surface_state.c >>>>> @@ -31,6 +31,7 @@ >>>>> >>>>> >>>>> #include "main/mtypes.h" >>>>> +#include "main/enums.h" >>>> >>>> I don't see why the new code below needs enums.h >>> >>> Oh...yeah. That was for _mesa_lookup_enum_by_name() during some >>> debugging. Probably should get taken back out. Good eye :) >> >> Yeah, I *really* wish that _mesa_lookup_enum_by_nr wasn't hidden in >> enums.h. Also that it had a guessable name that I didn't have to look >> up each time I'm trying to type it. > > Yeah, feel free to rename it. I'd go with something like > _mesa_enum_string().
How about _mesa_get_enum_name()? I also end up typing _mesa_get_format_name() all the time while debugging (and leaving that header include scattered around .c files), so matching those two up would be nice. Also it's pretty close to piglit_get_gl_enum_name(), which we type a lot too.
pgpeFOSyGuyoI.pgp
Description: PGP signature
_______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
