On Sat, Jul 14, 2012 at 10:20 PM, Marek Olšák <mar...@gmail.com> wrote: > On Sat, Jul 14, 2012 at 2:20 AM, Jerome Glisse <j.gli...@gmail.com> wrote: >> On Fri, Jul 13, 2012 at 8:02 PM, Marek Olšák <mar...@gmail.com> wrote: >>> Hi Jerome, >>> >>> I have a lot of remarks. >>> >>> 1) The DB decompression fix (where you update DB_RENDER_CONTROL) could >>> be in a separate patch. >>> >>> 2) The fix with EARLY_Z_THEN_LATE_Z (in update_dual_export) could also >>> be in a separate patch. >> >>> 3) r600_context::use_hyperz is set to FALSE by default, why? If the >>> fast clear works and there are no piglit regressions, then please >>> enable it. If the fast clear doesn't work reliably, please put it in a >>> branch. Merging non-working code on purpose is a very bad idea. >> >> Again it does work, but it has a non null probability to lockup gpu, >> probability depends on the gpu and application, but it can be quite >> high. So again code works but given it leads to lockup i dont want it >> to enable it by default. And I do intend to merge this. > > Fine. I guess it won't hurt much to have it in master.
I'd like to see this merged, but yeah, like Marek said split out some of the fixes from the rest of the big patch. Dave. _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
