On 11/07/2012 16:20, Eric Anholt wrote: > s/libglapi_la_CPPFLAGS/AM_CPPFLAGS/g may get you prettier build output > (at least with CFLAGS, it prepends the lib name to the .o files, which > affects build logs).
Thanks, that is a lot nicer :-) >> +noinst_LTLIBRARIES = libglapi.la >> + >> +libglapi_la_SOURCES = $(glapi_GLAPI_sources) $(glapi_ASM_sources) >> $(glapi_MAPI_sources) >> +libglapi_la_LIBADD = >> +libglapi_la_LDFLAGS = >> + >> +# list all possible sources, so automake understands what should be >> distributed >> +EXTRA_libglapi_la_SOURCES = $(X86_API) $(X86_64_API) $(SPARC_API) > > I don't think you need this if you're adding sources to the list using > automake conditionals, and you've removed autoconf substitutions from > the variables (which, afaik, is the reason for the "no autoconf > substitutions in SOURCES" rule.) Yes, this is probably an excess of caution. >> +# Provide compatibility with scripts for the old Mesa build system for >> +# a while by putting a link to libglapi.a here >> +all-local: libglapi.la >> + ln -sf .libs/libglapi.a libglapi.a > > This libglapi.a should be in CLEANFILES. Okay. I've added the compatibility links to CLEANFILES in the appropriate places in this patch sequence, but there are lots of pre-existing ones which don't do this. _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
