On 07/10/2012 11:42 AM, Kenneth Graunke wrote: > On 07/09/2012 10:46 AM, Chad Versace wrote: >> The header defined the functions in with C-style macro templates. Since >> there was only one user of the header, the templates were unnecessary. >> This patch redefines the functions as vanilla, non-templated functions. >> >> This patch also removes the header and folds its contents into >> texcompress_etc.c. The header defined many inline helper functions for >> texcompress_etc.c, but, since no other file included it, it never made >> sense to keep the header separate from the .c file. >> >> Signed-off-by: Chad Versace <chad.vers...@linux.intel.com> >> --- >> src/mesa/main/texcompress_etc.c | 119 +++++++++++++++++++++++++++++-- >> src/mesa/main/texcompress_etc_tmp.h | 136 >> ------------------------------------ >> 2 files changed, 112 insertions(+), 143 deletions(-) >> delete mode 100644 src/mesa/main/texcompress_etc_tmp.h > > This is also used by src/gallium/auxiliary/util/u_format_etc.c.
Argh, I fail at grep. I'll de-templatize the header but not delete it. > Otherwise, this series looks good to me! > Reviewed-by: Kenneth Graunke <kenn...@whitecape.org> _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
