On 2021-01-08 5:54 p.m., Chris Rankin wrote:
Hi,
I've just noticed a large drop in FPS (from 60 down to 15) when playing World
of Warcraft with the latest Mesa from Git.
A quick git bisect has identified this commit:
4292fb2139282e6906d4ad2a8be2fd81ed7ca8af is the first bad commit
commit 4292fb2139282e6906d4ad2a8be2fd81ed7ca8af
Author: Michel Dänzer <mdaen...@redhat.com>
Date: Mon Dec 21 15:41:56 2020 +0100
wsi/x11: Use PresentOptionAsync for MAILBOX present mode with Xwayland
This allows Xwayland to forward buffers to the Wayland compositor ASAP
for fullscreen / undecorated windows, which in turn allows true mailbox
behaviour in the Wayland compositor.
Without this, Xwayland has to emulate the mailbox behaviour itself,
which it cannot do as well as the Wayland compositor by design.
Reviewed-by: Bas Nieuwenhuizen <b...@basnieuwenhuizen.nl>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8197>
src/vulkan/wsi/wsi_common_x11.c | 7 +++++++
1 file changed, 7 insertions(+)
I am playing WoW with this release of Wine:
wine-6.0-0.4rc4.fc33.x86_64
And this version of DXVK:
wine-dxvk-1.7.2-3.fc33.x86_64
Curiously, I am using Xorg rather than Wayland, and so don't understand why
this commit should affect me.
Does the attached patch fix it?
P.S. Mesa uses GitLab issues for bug tracking now:
https://gitlab.freedesktop.org/mesa/mesa/-/issues
--
Earthling Michel Dänzer | https://redhat.com
Libre software enthusiast | Mesa and X developer
diff --git a/src/vulkan/wsi/wsi_common_x11.c b/src/vulkan/wsi/wsi_common_x11.c
index dcad48ca612..f204e329338 100644
--- a/src/vulkan/wsi/wsi_common_x11.c
+++ b/src/vulkan/wsi/wsi_common_x11.c
@@ -236,9 +236,9 @@ wsi_x11_connection_create(struct wsi_device *wsi_dev,
#endif
if (randr_reply && randr_reply->present != 0)
- {
wsi_conn->is_xwayland = wsi_x11_detect_xwayland(conn);
- }
+ else
+ wsi_conn->is_xwayland = false;
wsi_conn->has_dri3_modifiers = has_dri3_v1_2 && has_present_v1_2;
wsi_conn->is_proprietary_x11 = false;
_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
