Looks good, still r-b. But while we're here, let's get this right: > @@ -578,10 +578,8 @@ panfrost_transfer_map(struct pipe_context *pctx, > is_bound |= fb->cbufs[c]->texture == resource; > } > > - if (is_bound && (usage & PIPE_TRANSFER_READ)) { > - assert(level == 0); > - panfrost_flush_all_batches(ctx, true); > - } > + if (is_bound && (usage & PIPE_TRANSFER_READ)) > + assert(level == 0);
Everything from "Check if we're bound..." to "flush_all_batches()}" can be removed along with this commit :) I.e. just delete all the lines from L566 - L585 on master as of 46b7512b0a73 ... of course your line numbers are a bit different. _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev