On Tue, 17 Sep 2019 08:36:56 -0400 Alyssa Rosenzweig <aly...@rosenzweig.io> wrote:
> "Can't use pipe_framebuffer_state as a hash key" Is this still relevant? > I thought we did this. I did this yes. I thought it was only a problem for the wallpaper draw, but it's actually wrong for any kind of blit where src and dst point to the same resource, you're right. I guess the solution would be to not use util_framebuffer_state_equal() but compare the resources pointed by surfaces contained in the fb state, and not hash the fb state directly, but hash its resource pointers instead (pretty much what was done before my patch :-/). > > You're right that the 32-batch bitset is something we can integrate in a > v2. Ok. > > I guess that's it, never mind. Good stuff regardless :) Thanks. I'll apply patches that received R-bs and respin the rest of the series. _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
