> +out: > + if (ctx->batch == batch) > + panfrost_invalidate_frame(ctx);
Could you explain the logic a bit? I think the idea is that "if this is the bound batch, the panfrost_context parameters are relevant so submitting it invalidates those paramaters, but if it's not bound, the context parameters are for some other batch so we can't invalidate them". If so, this is good, just add a comment explaining so. > + /* We always stall the pipeline for correct results since pipelined > + * rendering is quite broken right now (to be fixed by the panfrost_job > + * refactor, just take the perf hit for correctness) > + */ > + drmSyncobjWait(pan_screen(ctx->base.screen)->fd, &ctx->out_sync, 1, > + INT64_MAX, 0, NULL); > + panfrost_free_batch(batch); Comment is borked but I think you'll reshuffle this later in the series so don't bother adjusting; I'm not that much of a pedant for commit history. --------------- Conditional on the added comment, you can make this R-b :) _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
