On 06/01/2012 12:06 PM, Brad King wrote: > Teach 'configure' to read the default GL_LIB, GLU_LIB, and OSMESA_LIB > values from the environment. This allows one to mangle the library > names (without also mangling the symbol names) to make them distinct > from other GL libraries on the system. > --- > > On 06/01/2012 10:06 AM, Brian Paul wrote: >> You should transition to using autoconf > > One feature I used in the pure-make build system was to create a custom > configs/current to set GL_LIB, GLU_LIB, and OSMESA_LIB to have a "Mesa" > prefix. This helps ensure that VTK both builds and runs against my > nightly Mesa build regardless of what other "GL" libraries appear in > the dynamic loader's search path. With this patch I can run > > $ GL_LIB=MesaGL GLU_LIB=MesaGLU OSMESA_LIB=MesaOSMesa ./autogen.sh ... > > to build with custom library names. Please review. > > Thanks, > -Brad
This looks good to me. The only real question I have is whether it makes sense to set them via environment variables, like you did, or whether it'd be better to use AC_ARG_WITH and do: ./autogen.sh --with-gl-lib-name=GL --with-glu-lib-name=GLU --with-osmesa-lib-name=OSMesa ... If people like the environment variables, this patch is Reviewed-by: Kenneth Graunke <kenn...@whitecape.org> and I'll be happy to push it upstream. Otherwise, it's a trivial change... Thoughts? Thanks for the patch and for bearing with us during the crazy automake transition :) _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
