On 28/08/2019 11:18, Michel Dänzer wrote:
> On 2019-08-28 3:08 a.m., Eric Engestrom wrote:
>> On Tuesday, 2019-08-27 13:31:22 +0000, Jose Fonseca wrote:
>>> Appveyor seems to be building other MR 1781:
>>>
>>>
>>> https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fci.appveyor.com%2Fproject%2Fmesa3d%2Fmesa-re1yd%2Fbuilds%2F26989425&data=02%7C01%7Cjfonseca%40vmware.com%7Cfe3cd31e967944da212808d72ba11193%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C0%7C637025843105542606&sdata=1UouYWYgyMdOVBEvlQgjByq3Scl2yyy%2FEJKfrIM7vNk%3D&reserved=0
>>>
>>> https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fci.appveyor.com%2Fproject%2Fmesa3d%2Fmesa-re1yd%2Fhistory&data=02%7C01%7Cjfonseca%40vmware.com%7Cfe3cd31e967944da212808d72ba11193%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C0%7C637025843105542606&sdata=uefH8tE%2F0i8D8hn8W9i%2BsS61OuPYrKoAVxNoJkBfS3c%3D&reserved=0
>>>
>>> https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitlab.freedesktop.org%2Feric%2Fmesa%2Fpipelines%2F59190&data=02%7C01%7Cjfonseca%40vmware.com%7Cfe3cd31e967944da212808d72ba11193%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C0%7C637025843105542606&sdata=wIlfbXS1USrnLRnLQJ5sMqDTtyQ2cDTYRolH6UezXco%3D&reserved=0
>>
>> You shouldn't take my MRs as an example for this, as I've set up the
>> hook on my account, so my MRs always get picked up by appveyor :)
>
> Yeah, the external integration settings are per GitLab project, and
> pre-merge CI pipelines for MRs run in the source project context, so the
> appveyor integration would need to be set up in each forked project used
> for MRs.
>
> This is a bit unfortunate, as it means the CI pipeline which runs (in
> the main project context) after an MR is merged could fail at the
> appveyor step, even if the pre-merge pipeline passed.
>
> Not sure what can be done about this though, other than requiring forked
> projects used for MRs to set up the appveyor integration as well.
>
>
That's unfortunate.
Though it looks like Appveyor is actually running MRs:
https://ci.appveyor.com/project/mesa3d/mesa-re1yd/builds/27008264
and notifying mesa-dev about failures:
https://lists.freedesktop.org/archives/mesa-dev/2019-August/222329.html
It's just unfortunate that there's no mention of it on the actual MR page
https://gitlab.freedesktop.org/mesa/mesa/merge_requests/1743
Caio, did you happen to receive any direct email from this?
If we can't get these MRs notifcations right, then I think we're better
off not running for MRs. To avoid spamming the list.
Jose
_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
