On Fri, Jun 1, 2012 at 9:52 PM, Eric Anholt <e...@anholt.net> wrote:
> On Fri,  1 Jun 2012 14:29:44 -0400, Kristian Høgsberg <k...@bitplanet.net> 
> wrote:
>> Currently, if you pass --with-egl-platforms=x11 but xcb-dri2 isn't available
>> we just silently fail and disables building the EGL DRI2 driver.
>>
>> This commit cleans up the EGL platfrom checking and fails if a selected
>> platform can't find its required dependencies.
>
>> +     wayland)
>> +             HAVE_EGL_DRIVER_DRI2=1
>>               PKG_CHECK_MODULES([WAYLAND], [wayland-client wayland-server],, 
>> \
>>                                 [AC_MSG_ERROR([cannot find 
>> libwayland-client])])
>> -                GALLIUM_WINSYS_DIRS="$GALLIUM_WINSYS_DIRS sw/wayland"
>> +             GALLIUM_WINSYS_DIRS="$GALLIUM_WINSYS_DIRS sw/wayland"
>> +
>> +             m4_ifdef([WAYLAND_SCANNER_RULES],
>> +                      
>> [WAYLAND_SCANNER_RULES(['$(top_srcdir)/src/egl/wayland/wayland-drm/protocol'])])
>> +             ;;
>> +
>
>
> I note that this also turns on HAVE_EGL_DRIVER_DRI2 for a few
> platforms.  That appears to be correct, but I wasn't expecting it from
> the commit mesage.

Ah, you're right, and that's problem if you're only looking to build
the gallium side of egl.  So we need to keep the enable_dri test and
enable HAVE_EGL_DRIVER_DRI2 if that's set, and then the platform
checks don't need to set it.  I'll send out v2.

Kristian
_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Reply via email to