On 2019-07-19 1:47 a.m., Rob Clark wrote: > On Thu, Jul 18, 2019 at 4:34 PM Roland Scheidegger <srol...@vmware.com> wrote: >> >> Am 16.07.19 um 20:55 schrieb AppVeyor: >>> >>> Build mesa 11902 failed >>> Commit 856e84083e by Rob Clark <mailto:robdcl...@chromium.org> on >>> 7/15/2019 4:05 PM: >>> mesa/st: add sampler uniforms\n\nAdd sampler uniforms for the UV >>> plane(s), so driver can count the\nuniforms and get the correct sampler >>> count.\n\nFixes lowered YUV on a6xx which actually wants to know # of >>> samplers.\n\nSigned-off-by: Rob Clark >>> <robdcl...@chromium.org>\nReviewed-by: Kristian H. Kristensen >>> <hoegsb...@google.com>\nReviewed-by: Eric Anholt <e...@anholt.net> >>> >> >> Apparently this commit broke windows builds... >> > > Hmm, really no asprintf() on windows? > > Is there some place we can add an asprintf() in mesa for windows builds?
Looks like the CI pipeline scons-win64 job needs to be tightened up: https://gitlab.freedesktop.org/mesa/mesa/-/jobs/425745 Maybe just make implicit function declarations errors in general? AFAICT that's already the case with meson. (At least this would need to be fixed first with scons: src/gallium/winsys/svga/drm/vmw_screen.c: In function 'vmw_dev_compare': src/gallium/winsys/svga/drm/vmw_screen.c:48:12: warning: implicit declaration of function 'major' [-Wimplicit-function-declaration] return (major(*(dev_t *)key1) == major(*(dev_t *)key2) && ^~~~~ src/gallium/winsys/svga/drm/vmw_screen.c:49:12: warning: implicit declaration of function 'minor'; did you mean 'mknod'? [-Wimplicit-function-declaration] minor(*(dev_t *)key1) == minor(*(dev_t *)key2)) ? 0 : 1; ^~~~~ mknod ) -- Earthling Michel Dänzer | https://www.amd.com Libre software enthusiast | Mesa and X developer _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
