On 06/01/2012 09:34 AM, Pekka Paalanen wrote:
> On Fri, 1 Jun 2012 09:18:44 +0300
> Pekka Paalanen <ppaala...@gmail.com> wrote:
>
>> On Thu, 31 May 2012 16:19:17 -0700
>> Kenneth Graunke <kenn...@whitecape.org> wrote:
>>
>>> Tungsten Graphics has not existed for several years, and the majority of
>>> ongoing development and support is done by Intel. I chose to include
>>> "Open Source Technology Center" to distinguish it from, say, the closed
>>> source Windows OpenGL driver.
>>>
>>> The one downside to this patch is that applications that pattern match
>>> against "Intel" may start applying workarounds meant for the Windows
>>> driver. However, it does seem like the right thing to do.
>>>
>>> This does change oglconform behavior.
>>>
>>> Acked-by: Eric Anholt <e...@anholt.net>
>>> Acked-by: Ian Romanick <ian.d.roman...@intel.com>
>>> Cc: Eugeni Dodonov <eug...@dodonov.net>
>>> Signed-off-by: Kenneth Graunke <kenn...@whitecape.org>
>>> ---
>>> src/mesa/drivers/dri/intel/intel_context.c | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/src/mesa/drivers/dri/intel/intel_context.c
>>> b/src/mesa/drivers/dri/intel/intel_context.c
>>> index 9deb4ca..712acb8 100644
>>> --- a/src/mesa/drivers/dri/intel/intel_context.c
>>> +++ b/src/mesa/drivers/dri/intel/intel_context.c
>>> @@ -72,7 +72,7 @@ intelGetString(struct gl_context * ctx, GLenum name)
>>>
>>> switch (name) {
>>> case GL_VENDOR:
>>> - return (GLubyte *) "Tungsten Graphics, Inc";
>>> + return (GLubyte *) "Intel® Open Source Technology Center";
>>
>> Hi,
>>
>> that is an utf-8 character there, right?
>> Is that really appropriate, given the API and all?
>>
>> I don't know about character encoding stuff, but that looks surprising.
>> Just wondering...
>
> Oops, sorry, I missed the other replies. Let me rephrase:
> is it ok by the GL spec to return non-ASCII strings here?OpenGL 3.0 spec says: "String queries return pointers to UTF-8 encoded, NULL-terminated static strings describing properties of the current GL context." Current GL ES specs do not define anything about the encoding. > > Thanks, > pq > _______________________________________________ > mesa-dev mailing list > mesa-dev@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/mesa-dev -- // Tapani
signature.asc
Description: OpenPGP digital signature
_______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
