Eric Engestrom <e...@engestrom.ch> writes: > On Saturday, 2019-06-29 22:59:21 +0200, apinheiro wrote: >> >> On 29/6/19 2:30, Rob Clark wrote: >> > I had interpreted it as literally the "block the gitlab merge button" >> > option, ie. "I want to get feedback but it is not ready to merge and >> > I'll drop the WIP tag when I think it is".. >> >> >> > >> > (comments inline) >> > >> > On Fri, Jun 28, 2019 at 5:12 PM Ian Romanick <i...@freedesktop.org> wrote: >> > > After a conversation yesterday with a couple of the other Intel devs, >> > > I've come to the conclusion that *everyone* interprets WIP to mean >> > > something different. I heard no less than four interpretations. >> > > >> > > * This series is good. It hasn't been reviewed, so don't click "merge." >> > isn't that the point of a MR.. doesn't seem like a reason for "WIP" >> >> >> I agree with Rob here. What I understand of WIP is that there is some reason >> that prevents a MR to be merged, even if I still want it to be reviewed, or >> if it is fully reviewed. For example, I send a MR with patches that I think >> that are correct, so people can start to review it. But on a rebase, I found >> that the branch causes regressions on piglit/cts/whatever. I still think >> that the patches are correct, but those regressions need to be investigated >> before pushing. So I just add a WIP on the MR to prevent to be merged by >> mistake. > > Kind of just saying "+1" here, but yeah that's also my understanding of "WIP".
+1 "WIP" is for "There is some issue with this (other than lack of review) that prevents merging, so disable the merge button."
signature.asc
Description: PGP signature
_______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
